[DPE-4416] Fetch charm libs to the latest LIBPATCH (update dp-libs to v36 to fix secrets issue) #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taurus-forever
changed the title
taurus-forever
requested review from
marceloneppel,
dragomirp and
lucasgameiroborges
|
I have reverted rolling-ops update due to requirements to tune unit-tests there: https://github.com/canonical/postgresql-operator/actions/runs/9251766314/job/25447979712 (not a scope to fix secrets on upgrade). |
marceloneppel
approved these changes
May 27, 2024
lucasgameiroborges
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
It is impossible to upgrade charm from the current 14/stable to 14/candidate due to the issue https://warthogs.atlassian.net/browse/DPE-4416
Solution:
Fix dp-library in revision 36 canonical/data-platform-libs#170
Update all libraries to the latest fixes/LIBPATCH.
Original issue is no longer reproducible and the new charm passed the internal testing.